Defer user creation until email verification - #2952
Open
RabbiIslamRony wants to merge 1 commit into
Open
Conversation
2 tasks
Member
Author
|
The PHPCS job stopped at the inherited actions/checkout@v3 step before repository checkout or PHP analysis. The current base workflow uses pull_request_target for fork code, and checkout now refuses that privileged operation. PR #2945 updates the shared workflow to a read-only pull_request job; once that workflow lands, this branch can be rerun normally. Locally, all seven changed PHP files pass PHP 8.2 syntax checks and the repository PHPCS rules with zero errors, and the new pending-registration class also has zero warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
How to reproduce the issue or how to test the changes
The pending-registration table is installed idempotently with its own schema version. Pending links expire after 24 hours, tokens are stored only as HMACs, request limits are privacy-safe, and token claiming is transactional to prevent duplicate account creation.
Any linked issues
Fixes #1671
Checklist