Preserve IIS temporary paths during uploads and directory import - #2948
Open
RabbiIslamRony wants to merge 1 commit into
Open
Preserve IIS temporary paths during uploads and directory import#2948RabbiIslamRony wants to merge 1 commit into
RabbiIslamRony wants to merge 1 commit into
Conversation
Member
Author
|
The PHPCS job stopped before code checkout because the current development-branch workflow still uses pull_request_target and actions/checkout refuses fork code in that privileged context. No project code or PHPCS command ran. The infrastructure failure is addressed by #2945; this check should be rerun after that PR merges. Both changed PHP files have zero PHPCS errors locally, with the pre-existing warning count unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
How to reproduce the issue or how to test the changes
C:\Program Files\PHPv8.1\upload\phpAC39.tmp, retains every backslash beforewp_handle_upload()and the upload succeeds.Verification completed:
wp_unslash()behavior reproduced the corruption.git diff --checkpassed, and all temporary database, plugin, directory, field, and upload-file fixtures were removed.Any linked issues
Fixes #1356
Checklist