You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're gonna have to write some test :) Testing for murfie not so important, but testing for libs like this is huge. People will use it in all kinds of ways and we need to know it will do what we expect it too.
I figured it wasn't ideal haha. It was good to get that all written down
though to learn how to do it that way. I'll check out the active admin one
and send another PR for review. I don't really understand what's going on
with travis so I might wait to do some testing with you
We're gonna have to write some test :) Testing for murfie not so
important, but testing for libs like this is huge. People will use it in
all kinds of ways and we need to know it will do what we expect it too.
2.
can we go through what coding this up would be like? It's still slightly nebulous, I'm not sure I can navigate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is this the kind of thing you're looking for?