feat!: replace secure-mode shell_exec with typed tools - #31
Merged
Conversation
…in writeFile/editFile/mkdir/move/delete/git tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original motivation
1. 🎯 Desired functionality: secure mode exposes typed MCP tools whose argv is built by the server. ├── 1.1. Client parameters are values only and never land in a flag position. ├── 1.2. Example: git_log with {"max_count": 5, "path": "README.md"} runs git log --no-color -n5 --format=... --end-of-options HEAD -- README.md. └── 1.3. Every path is resolved with symlinks and must stay under working_directory. 2. 🔁 Best current alternative: 0.8.x shell_exec with unfurling plus per-executable deny/allow argument policies. ├── 2.1. Seven advisories since May (latest GHSA-xvpv-9qcq-636h, --cont abbreviating --contents) came from that model. └── 2.2. Git accepts any unambiguous long-option prefix, so a flag denylist cannot be completed.Existing limitation
Implementation strategy
Code added
Code changed
Testing
For More Human Review
tools_git.gogit_blame passes the path without a literal--because git rejects--end-of-options <ref> -- <path>on blame; the leading-dash guard inrelPathcovers it.tools_git.gogit_switch emits-c <branch> --end-of-optionsbecause-cneeds the name right after it.config.goloadSecurityFromFile decodes the yaml twice, once into a map for the removed-key check.