fix(security): deny abbreviated forms of denied git long options - #29
Merged
Conversation
git's parse-options accepts any unambiguous prefix of a long option, so `git blame --cont=/etc/passwd -- f` bypassed the exact-match denylist for --contents (GHSA-xvpv-9qcq-636h). The same held for --out (--output), --ext (--ext-diff), --open (--open-files-in-pager) and --textc (--textconv). gitDeniedFlag now rejects any long flag that is a prefix of a denied option, ambiguous or not, failing closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GHSA-xvpv-9qcq-636h.
git's parse-options accepts any unambiguous prefix of a long option, so
git blame --cont=/etc/passwd -- fbypassed the exact-match denylist for--contents. Same for--out,--ext,--open,--textc.gitDeniedFlagnow rejects any long flag that is a prefix of a denied option, ambiguous or not. Fails closed.Local gate:
go vet ./... && go test ./...green. Hosted CI is disabled on this account (billing), red checks are noise.