debian/rules: restore the executable bit - #41
Open
munibshah wants to merge 1 commit into
Open
Conversation
dpkg-buildpackage invokes debian/rules directly, so it has to be executable. It is currently recorded in git as mode 100644, so a fresh clone checks it out non-executable and the package build has to be fixed up by hand before it will run. sonic-bmp looks like the only SONiC component affected: of the 24 submodules under sonic-buildimage's src/ that ship a debian/rules, the other 23 are all mode 100755. Permission bit only - no content change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
|
/azp run |
One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via: Supported
Alternatively, if the co-author should not be included, remove the Please update your commit message(s) by doing |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
dpkg-buildpackageinvokesdebian/rulesdirectly, so the file has to be executable. It is currently recorded in git as mode100644, which means a fresh clone checks it out non-executable and the package build has to be fixed up by hand before it will run.sonic-bmpappears to be the only SONiC component affected. Of the 24 submodules undersonic-buildimage'ssrc/that ship adebian/rules, the other 23 are all mode100755—src/sonic-bmpis the sole100644.Practical symptom: after
make init,src/sonic-bmpshows as a dirty submodule with a mode-only diff, because the bit has to be reapplied locally to build.How I did it
Permission bit only. The blob hash is unchanged (
2d33f6ac8992b7da84b39a5bca0742c4962d3349), so there is no content diff.How to verify it
A fresh clone then checks the file out executable, and
src/sonic-bmpno longer shows up as a dirty submodule in asonic-buildimagetree.