Skip to content

debian/rules: restore the executable bit - #41

Open
munibshah wants to merge 1 commit into
sonic-net:masterfrom
munibshah:fix/debian-rules-executable
Open

debian/rules: restore the executable bit#41
munibshah wants to merge 1 commit into
sonic-net:masterfrom
munibshah:fix/debian-rules-executable

Conversation

@munibshah

Copy link
Copy Markdown

Why I did it

dpkg-buildpackage invokes debian/rules directly, so the file has to be executable. It is currently recorded in git as mode 100644, which means a fresh clone checks it out non-executable and the package build has to be fixed up by hand before it will run.

sonic-bmp appears to be the only SONiC component affected. Of the 24 submodules under sonic-buildimage's src/ that ship a debian/rules, the other 23 are all mode 100755src/sonic-bmp is the sole 100644.

Practical symptom: after make init, src/sonic-bmp shows as a dirty submodule with a mode-only diff, because the bit has to be reapplied locally to build.

How I did it

git update-index --chmod=+x debian/rules

Permission bit only. The blob hash is unchanged (2d33f6ac8992b7da84b39a5bca0742c4962d3349), so there is no content diff.

How to verify it

git ls-files -s debian/rules
# before: 100644 2d33f6ac... 0    debian/rules
# after:  100755 2d33f6ac... 0    debian/rules

A fresh clone then checks the file out executable, and src/sonic-bmp no longer shows up as a dirty submodule in a sonic-buildimage tree.

dpkg-buildpackage invokes debian/rules directly, so it has to be
executable. It is currently recorded in git as mode 100644, so a fresh
clone checks it out non-executable and the package build has to be fixed
up by hand before it will run.

sonic-bmp looks like the only SONiC component affected: of the 24
submodules under sonic-buildimage's src/ that ship a debian/rules, the
other 23 are all mode 100755.

Permission bit only - no content change.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@linux-foundation-easycla

Copy link
Copy Markdown

CLA Missing ID

One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via:

Co-authored-by: name <email>

Supported Co-authored-by: formats include:

  1. Anything <id+login@users.noreply.github.com> - it will locate your GitHub user by id part.
  2. Anything <login@users.noreply.github.com> - it will locate your GitHub user by login part.
  3. Anything <public-email> - it will locate your GitHub user by public-email part. Note that this email must be made public on Github.
  4. Anything <other-email> - it will locate your GitHub user by other-email part but only if that email was used before for any other CLA as a main commit author.
  5. login <any-valid-email> - it will locate your GitHub user by login part, note that login part must be at least 3 characters long.

Alternatively, if the co-author should not be included, remove the Co-authored-by: line from the commit message.

Please update your commit message(s) by doing git commit --amend and then git push [--force] and then request re-running CLA check via commenting on this pull request:

/easycla

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants