Use core's capybara driver configuration#236
Open
mamhoff wants to merge 1 commit intosolidusio:mainfrom
Open
Conversation
Solidus core has migrated to using Firefox for headless testing, which seems to be more stable than Chrome, and uses minimal configuration. See solidusio/solidus#6230 Because older versions of Solidus might not have the new `capybara_driver.rb` file, we still include the legacy code in a `rescue` block.
mamhoff
force-pushed
the
use-core-capybara-config
branch
from
2da0c6d to
69e1eb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solidus core has migrated to using Firefox for headless testing, which seems to be more stable than Chrome, and uses minimal configuration.
See solidusio/solidus#6230
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: