Repository navigation
Conversation
- Added form fields for shipping method details, pricing, taxation, availability, and organization. - Implemented JavaScript to toggle stock location visibility based on checkbox state. - Added translations for the form component.
- Updated routes to include all actions except `show` for shipping methods. - Added locale translations for shipping method actions.
- Updated the index component to use new paths for editing and creating shipping methods. - Added links to edit shipping methods directly from the index.
- Refactored the controller to use `SolidusAdmin::ResourcesController`. - Updated permitted parameters to include new fields.
- Added a dropdown to select calculator type and render preferences based on the selected type. - Implemented JavaScript to toggle visibility of preferences based on the selected calculator type.
This change uses the shared preference fields in the shipping calculator form component instead of re-defining these fields again. This allows us to have a shared implementation for both shipping calculators and payment methods. Co-authored-by: Senem Soy <senem@super.gd>
- Added fields using form component. - Added translations for the new component. - Added feature spec for shipping method creation.
- Added fields using form component. - Added translations for the edit component. - Added feature spec to edit exisiting shipping method.
This change introduces a new request spec for the new admin shipping methods controller. The spec follows the same pattern as existing specs for admin controllers and uses the same shared examples to cover the CRUD actions.
This was referenced Nov 20, 2026
Draft
forkata
marked this pull request as draft
November 20, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change is a fresh take on #6232 with some modifications to update the original PR to the current state of the new admin.
Some of the notable changes here:
#typeand#preference_source#6706required: trueto the name and shipping category fields (see note below on the TomSelect behaviour gap for this)A few notable things missing from the original PR as well as this change:
#resource_formthat can surface errors not tied to a field. This should be tackled in a separate change as it is missing from all admin forms - the old admin used a separate partial rendered inside the form, we can follow that pattern or use a flash.solidus_selectsare highlighted but show no native browser tooltip, becausesolidus_select.jssets hidden on the native select. We need a small JS snippet to forward the invalid event to the TomSelect visible input element. This should also be done in a separate PR.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: