Skip to content

Admin][Settings][Shipments] Introduce shipping method creation and modification capability - #6744

Draft
forkata wants to merge 9 commits into
solidusio:mainfrom
SuperGoodSoft:forkata/shipping-methods-admin
Draft

forkata wants to merge 9 commits into
solidusio:mainfrom
SuperGoodSoft:forkata/shipping-methods-admin

Conversation

@forkata

@forkata forkata commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This change is a fresh take on #6232 with some modifications to update the original PR to the current state of the new admin.

Some of the notable changes here:

A few notable things missing from the original PR as well as this change:

  • We don't have a shared error-summary component, rendered inside #resource_form that can surface errors not tied to a field. This should be tackled in a separate change as it is missing from all admin forms - the old admin used a separate partial rendered inside the form, we can follow that pattern or use a flash.
  • Required solidus_selects are highlighted but show no native browser tooltip, because solidus_select.js sets hidden on the native select. We need a small JS snippet to forward the invalid event to the TomSelect visible input element. This should also be done in a separate PR.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

JustShah and others added 9 commits November 19, 2026 15:50
- Added form fields for shipping method details, pricing, taxation, availability, and organization.
- Implemented JavaScript to toggle stock location visibility based on checkbox state.
- Added translations for the form component.
- Updated routes to include all actions except `show` for shipping methods.
- Added locale translations for shipping method actions.
- Updated the index component to use new paths for editing and creating
  shipping methods.
- Added links to edit shipping methods directly from the index.
- Refactored the controller to use `SolidusAdmin::ResourcesController`.
- Updated permitted parameters to include new fields.
- Added a dropdown to select calculator type and render preferences based on the selected type.
- Implemented JavaScript to toggle visibility of preferences based on the selected calculator type.
This change uses the shared preference fields in the shipping calculator
form component instead of re-defining these fields again. This allows us
to have a shared implementation for both shipping calculators and
payment methods.

Co-authored-by: Senem Soy <senem@super.gd>
- Added fields using form component.
- Added translations for the new component.
- Added feature spec for shipping method creation.
- Added fields using form component.
- Added translations for the edit component.
- Added feature spec to edit exisiting shipping method.
This change introduces a new request spec for the new admin shipping
methods controller. The spec follows the same pattern as existing specs
for admin controllers and uses the same shared examples to cover the
CRUD actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants