Skip to content

Add user creation flow to solidus_admin - #6742

Merged
AlistairNorman merged 5 commits into
solidusio:mainfrom
benjaminwil:user-create-resources
Nov 19, 2026
Merged

AlistairNorman merged 5 commits into
solidusio:mainfrom
benjaminwil:user-create-resources

Conversation

@benjaminwil

@benjaminwil benjaminwil commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This adds the user create flow to solidus_admin. Some work had been missed when the update flows were added (i.e. password fields were shown as text), so I have included that work as well to satisfy the requirements.

Note that this work gets us to parity with solidus_backend but does not yet implement the user invitation flow described here: #6743.

Screenshot

Before this, the admin redirected to the legacy backend views. Now:

The user creation modal activated

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@codecov

codecov Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.68%. Comparing base (c7914f5) to head (7278ae1).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
.../app/controllers/solidus_admin/users_controller.rb 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6742      +/-   ##
==========================================
+ Coverage   92.63%   92.68%   +0.04%     
==========================================
  Files        1077     1083       +6     
  Lines       21852    22010     +158     
==========================================
+ Hits        20242    20399     +157     
- Misses       1610     1611       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjaminwil
benjaminwil force-pushed the user-create-resources branch from 33e2e78 to 10c7c21 Compare November 18, 2026 20:18
@benjaminwil
benjaminwil marked this pull request as ready for review November 18, 2026 20:44
@benjaminwil
benjaminwil requested a review from a team as a code owner November 18, 2026 20:45
@benjaminwil
benjaminwil force-pushed the user-create-resources branch from 10c7c21 to de5368f Compare November 18, 2026 20:47

@tvdeyen tvdeyen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on that password field 🙈. We should allow to pass autocomplete values, though.

@benjaminwil
benjaminwil force-pushed the user-create-resources branch from e677c37 to 3c9d185 Compare November 19, 2026 17:25
When the `solidus_admin` user update forms were added, it looks like no
one bothered to use a password-type input for passwords.
I just happened to spot these when I was updating this file in a parent
commit.
This moves the user creation flow from the legacy backend views to a
`solidus_admin` modal flow.
We should only have one `<header>` per page. To fix the presentation,
I needed to wrap the tabs in a `<div>`.
@benjaminwil
benjaminwil force-pushed the user-create-resources branch from 3c9d185 to 7278ae1 Compare November 19, 2026 18:15
@benjaminwil benjaminwil self-assigned this Nov 19, 2026
@benjaminwil
benjaminwil requested a review from tvdeyen November 19, 2026 18:32
@AlistairNorman
AlistairNorman merged commit b1e1977 into solidusio:main Nov 19, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants