Repository navigation
Add user creation flow to solidus_admin - #6742
Merged
AlistairNorman merged 5 commits intoNov 19, 2026
Merged
Conversation
benjaminwil
force-pushed
the
user-create-resources
branch
from
November 18, 2026 19:27
edabed6 to
33e2e78
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6742 +/- ##
==========================================
+ Coverage 92.63% 92.68% +0.04%
==========================================
Files 1077 1083 +6
Lines 21852 22010 +158
==========================================
+ Hits 20242 20399 +157
- Misses 1610 1611 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
benjaminwil
force-pushed
the
user-create-resources
branch
from
November 18, 2026 20:18
33e2e78 to
10c7c21
Compare
benjaminwil
marked this pull request as ready for review
November 18, 2026 20:44
benjaminwil
force-pushed
the
user-create-resources
branch
from
November 18, 2026 20:47
10c7c21 to
de5368f
Compare
tvdeyen
requested changes
Nov 18, 2026
tvdeyen
left a comment
Member
There was a problem hiding this comment.
Nice catch on that password field 🙈. We should allow to pass autocomplete values, though.
benjaminwil
force-pushed
the
user-create-resources
branch
from
November 18, 2026 22:14
de5368f to
e677c37
Compare
3 tasks
tvdeyen
reviewed
Nov 18, 2026
benjaminwil
force-pushed
the
user-create-resources
branch
from
November 19, 2026 17:25
e677c37 to
3c9d185
Compare
When the `solidus_admin` user update forms were added, it looks like no one bothered to use a password-type input for passwords.
I just happened to spot these when I was updating this file in a parent commit.
This moves the user creation flow from the legacy backend views to a `solidus_admin` modal flow.
We should only have one `<header>` per page. To fix the presentation, I needed to wrap the tabs in a `<div>`.
benjaminwil
force-pushed
the
user-create-resources
branch
from
November 19, 2026 18:15
3c9d185 to
7278ae1
Compare
tvdeyen
approved these changes
Nov 19, 2026
AlistairNorman
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the user create flow to
solidus_admin. Some work had been missed when the update flows were added (i.e. password fields were shown as text), so I have included that work as well to satisfy the requirements.Note that this work gets us to parity with
solidus_backendbut does not yet implement the user invitation flow described here: #6743.Screenshot
Before this, the admin redirected to the legacy backend views. Now:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: