refactor: migrate to solid_lints 1.0.0-dev.1 plugin and fix lints - #102
Open
andrew-bekhiet-solid wants to merge 5 commits into
Open
refactor: migrate to solid_lints 1.0.0-dev.1 plugin and fix lints#102andrew-bekhiet-solid wants to merge 5 commits into
andrew-bekhiet-solid wants to merge 5 commits into
Conversation
refactor: reduce cyclomatic complexity of some methods refactor: reduce numbers of parameters by extracting a class docs: update changelog
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change groups match location, mistake colors, and popup styling into public configuration models, updates parsing and rendering integrations, moves the example UI into a separate app file, and migrates lint checks from ChangesModel and UI configuration refactor
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant App
participant LanguageToolTextField
participant LanguageToolController
participant LanguageToolService
App->>LanguageToolTextField: provide text field and mistake popup
LanguageToolTextField->>LanguageToolController: submit edited text
LanguageToolController->>LanguageToolService: request throttled spell check
LanguageToolService-->>LanguageToolController: return detected mistakes
LanguageToolController-->>LanguageToolTextField: render highlighted mistakes
LanguageToolTextField-->>App: add ignored word and recheck text
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lib/src/core/controllers/language_tool_controller.dart`:
- Around line 486-493: Update the layout and offset handling around TextPainter
in the relevant controller method: keep maxWidth constrained to textFieldWidth
for vertically scrolled multiline text, and apply scrollOffset to dy. Use
unbounded width with dx adjustment only for horizontal single-line scrolling,
preserving wrapped text alignment and correct popup selection after vertical
scrolling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 678e4175-1cfa-4d2e-90b2-8f59a5e769bb
📒 Files selected for processing (18)
.github/workflows/code_check.yamlCHANGELOG.mdanalysis_options.yamlexample/analysis_options.yamlexample/lib/app.dartexample/lib/main.dartexample/pubspec.yamllib/languagetool_textfield.dartlib/src/client/language_tool_client.dartlib/src/core/controllers/language_tool_controller.dartlib/src/core/model/match.dartlib/src/core/model/match_location.dartlib/src/domain/highlight_style.dartlib/src/domain/mistake_colors.dartlib/src/domain/mistake_popup_style.dartlib/src/presentation/language_tool_text_field.dartlib/src/utils/mistake_popup.dartpubspec.yaml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lib/src/presentation/language_tool_text_field.dart`:
- Around line 220-222: Update _textControllerListener registration so it also
listens to _scrollController scroll events, ensuring scrollOffset and scrollAxis
stay current during scrolling; remove the same listener from _scrollController
in dispose() while preserving the existing controller listener cleanup.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: eb9effb1-2a1e-434e-b020-bb74c714774b
📒 Files selected for processing (3)
CHANGELOG.mdlib/src/core/controllers/language_tool_controller.dartlib/src/presentation/language_tool_text_field.dart
🚧 Files skipped from review as they are similar to previous changes (1)
- CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: reduce cyclomatic complexity of some methods
refactor: reduce numbers of parameters by extracting a class
docs: update changelog
Summary by CodeRabbit