Skip to content

feat: rotating file writer#913

Merged
mdydek merged 11 commits intomainfrom
feat/more_file_writer_impls
Apr 13, 2026
Merged

feat: rotating file writer#913
mdydek merged 11 commits intomainfrom
feat/more_file_writer_impls

Conversation

@poneciak57
Copy link
Copy Markdown
Contributor

@poneciak57 poneciak57 commented Jan 24, 2026 •
edited by mdydek
Loading

Closes RNAA-384

⚠️ Breaking changes ⚠️

  • start and enableFileOutput does not output anything additional when status is success
  • stop returns list of paths instead of single one, but when file rotation is disabled it returns only one element

Introduced changes

  • implemented rotating file writer

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

@poneciak57 poneciak57 changed the title feat: file writer extension feat: rotating file writer Jan 29, 2026
@poneciak57 poneciak57 marked this pull request as ready for review January 29, 2026 14:58
michalsek
michalsek reviewed Feb 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@michalsek michalsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to rething start/stop methods when rotating is enabled, returning filepath on start, and only signle path on stop (with metadata) would be weird.

We could consider slightly improving the results by having:

  • Only status return when start/stop is called without file output
  • Single/path meta for normal file output
  • Parent directory(?) for the rotating files or only status at start, list of files (or parent directory) on stop for batched files

Although not a strong opinion on the approach

mdydek
mdydek requested changes Feb 17, 2026
View reviewed changes
Comment thread packages/react-native-audio-api/src/types.ts
Comment thread ...udio-api/android/src/main/cpp/audioapi/android/core/utils/ffmpegBackend/FFmpegFileWriter.cpp Outdated
Comment thread packages/react-native-audio-api/common/cpp/audioapi/core/utils/RotatingFileWriter.cpp
Comment thread ...s/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp Outdated
Comment thread ...s/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp Outdated
Comment thread ...s/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp Outdated
Comment thread packages/react-native-audio-api/common/cpp/audioapi/core/utils/RotatingFileWriter.cpp Outdated
Comment thread packages/react-native-audio-api/common/cpp/audioapi/core/utils/AudioFileWriter.h Outdated
Comment thread packages/react-native-audio-api/ios/audioapi/ios/core/utils/IOSFileWriter.mm Outdated
Comment thread packages/react-native-audio-api/ios/audioapi/ios/core/IOSAudioRecorder.mm Outdated
@mdydek mdydek added the feature New feature label Apr 13, 2026
@mdydek mdydek merged commit 51c880c into main Apr 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsek michalsek michalsek left review comments

@mdydek mdydek mdydek approved these changes

@maciejmakowski2003 maciejmakowski2003 Awaiting requested review from maciejmakowski2003

Assignees

No one assigned

Labels

feature New feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@poneciak57 @michalsek @mdydek