Skip to content

fix(ufm): render alll finding locations, report URL and target file info#6754

Merged
CatalinSnyk merged 1 commit intomainfrom
fix/cli-1329_sarifMultiLocationRendering
Apr 29, 2026
Merged

fix(ufm): render alll finding locations, report URL and target file info#6754
CatalinSnyk merged 1 commit intomainfrom
fix/cli-1329_sarifMultiLocationRendering

Conversation

@j-luong
Copy link
Copy Markdown
Contributor

@j-luong j-luong commented Apr 29, 2026

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Updates the UFM SARIF rendering template to include all finding locations, where applicable, instead of just the first location

LE: Also includes a fix to render all finding locations in the SARIF output from the UFM presenter, along with the WebUI report URL when the TestResult metadata for reportUrl is being set.

Where should the reviewer start?

Related GAF PRs:

How should this be manually tested?

For a product that supports multiple finding locations (e.g. secrets) run a test command with --sarif flag applied. If a project has findings with multiple finding locations, they should be output correctly.

Adding the --report flag to the command above should also show up with the WebUI links to the scanned project page.

An open source scan with the --reachability and --all-projects enabled should make it easier to distinguish which Test Summary is for which subproject. The Target file label should present the manifest file being scanned for the subprojects.

What's the product update that needs to be communicated to CLI users?

N/A at this time around.

@j-luong j-luong requested review from a team as code owners April 29, 2026 10:08
@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Apr 29, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Warnings
⚠️

"fix(ufm): render alll finding locations, report URL and target file info" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 59017f3

@CatalinSnyk CatalinSnyk force-pushed the fix/cli-1329_sarifMultiLocationRendering branch from 6cb54cd to 59017f3 Compare April 29, 2026 14:35
@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 4 relevant code sections from 2 files (average relevance: 0.80)

@CatalinSnyk CatalinSnyk changed the title fix: sarif rendering now includes all finding locations fix(ufm): render alll finding locations, report URL and target file info Apr 29, 2026
@CatalinSnyk CatalinSnyk enabled auto-merge April 29, 2026 15:14
@CatalinSnyk CatalinSnyk merged commit eb0dd7c into main Apr 29, 2026
11 checks passed
@CatalinSnyk CatalinSnyk deleted the fix/cli-1329_sarifMultiLocationRendering branch April 29, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants