fix(ufm): render alll finding locations, report URL and target file info#6754
Merged
CatalinSnyk merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
6cb54cd to
59017f3
Compare
PR Reviewer Guide 🔍
|
CatalinSnyk
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Updates the UFM SARIF rendering template to include all finding locations, where applicable, instead of just the first location
LE: Also includes a fix to render all finding locations in the SARIF output from the UFM presenter, along with the WebUI report URL when the TestResult metadata for
reportUrlis being set.Where should the reviewer start?
Related GAF PRs:
How should this be manually tested?
For a product that supports multiple finding locations (e.g. secrets) run a test command with
--sarifflag applied. If a project has findings with multiple finding locations, they should be output correctly.Adding the
--reportflag to the command above should also show up with the WebUI links to the scanned project page.An open source scan with the
--reachabilityand--all-projectsenabled should make it easier to distinguish which Test Summary is for which subproject. TheTarget filelabel should present the manifest file being scanned for the subprojects.What's the product update that needs to be communicated to CLI users?
N/A at this time around.