Skip to content

bench: expose TreeDB vector comparator e2e knobs#1746

Open
snissn wants to merge 1 commit into
codex/issue-1739-vacuumed-vector-storagefrom
codex/vector-db-compare-treedb-e2e-knobs
Open

bench: expose TreeDB vector comparator e2e knobs#1746
snissn wants to merge 1 commit into
codex/issue-1739-vacuumed-vector-storagefrom
codex/vector-db-compare-treedb-e2e-knobs

Conversation

@snissn
Copy link
Copy Markdown
Owner

@snissn snissn commented May 22, 2026

Follow-up to #1745.

This extends the vector DB comparison harness so the new production column-store path can be exercised with the same end-to-end correctness/storage knobs as treedb_vector_search_demo.

Changes:

  • add VALIDATE_DOCS plumbing for TreeDB comparator runs
  • add TreeDB compaction controls: TREEDB_COMPACT, TREEDB_COMPACT_SYNC_EACH_PHASE
  • add TreeDB storage-layout assertion/override envs: TREEDB_VALUE_POINTER_THRESHOLD, TREEDB_LEAF_GENERATION_SEGMENT_TARGET, TREEDB_REQUIRE_VALUE_LOG_BYTES, TREEDB_REQUIRE_LEAF_VLOG_BYTES
  • share common TreeDB args across native and treedb_column_graph comparator cases

Smoke/parity checks run:

  • go test ./cmd/treedb_vector_search_demo ./cmd/treedb_vector_dataset_export
  • go test ./TreeDB/collections -run 'Test(SearchVectorIndexColumnGraph|ColumnVectorGraphNativeSearch|ColumnGraphRebuild|ColumnGraphVectorIndexStatus)'\n- bash -n scripts/bench_vector_db_compare.sh\n- small TreeDB column_graph vs pgvector comparator smoke\n- small compacted TreeDB column_graph comparator smoke\n- small TreeDB/native + column_graph + vectorlite + pgvector matrix smoke\n

Copilot AI review requested due to automatic review settings May 22, 2026 21:26
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1134e0ee-d4c0-4911-8a80-eadbe22c2792

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/vector-db-compare-treedb-e2e-knobs

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants