feat: various changes to accomodate new wf catalog features#27
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughUpdates include a license year range bump, small README edits, removal of a parameters table from config docs, repositioning of a Snakemake Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@workflow/schemas/config.schema.yaml`:
- Around line 15-18: The schema currently sets a required field
get_genome.ncbi_ftp with default: "" which makes an empty-but-present value
possible; remove the empty default (delete default: "") and instead add a
non-empty constraint (e.g., minLength: 1 or a URI/hostname pattern) for property
ncbi_ftp so the validator rejects blank values; update any docs/examples rather
than changing requiredness, and ensure the consumer in process_reads.smk (the
wget usage) will only receive a validated, non-empty URL.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 49921d3a-d7eb-4c43-b462-a5dd4c45e143
📒 Files selected for processing (6)
LICENSEREADME.mdconfig/README.mdworkflow/Snakefileworkflow/rules/process_reads.smkworkflow/schemas/config.schema.yaml
💤 Files with no reviewable changes (1)
- config/README.md
dlaehnemann
left a comment
There was a problem hiding this comment.
Nice. I didn't know about these features, but appreciate them.
One additional thing to maybe add, would be extensive comments in the config/config.yaml file itself. But this could also be done in a separate pull request. This is where I usually put information on the kinds of values each setting can have.
.testsubdir which supports running a test case (snakemake -c 1 -d .test --forceall --rulegraph)Summary by CodeRabbit
New Features
Documentation
Dependencies
Chores