Repository navigation
Conversation
Contributor
📊 API Diff Results
|
bolekk
changed the title
bolekk
force-pushed
the
dontime-deprecate-limit-by-batch-size-flag
branch
from
November 9, 2026 03:26
b7d345d to
5b27d23
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bolekk
force-pushed
the
dontime-deprecate-limit-by-batch-size-flag
branch
from
November 9, 2026 03:27
5b27d23 to
0c8d18f
Compare
bolekk
marked this pull request as ready for review
November 9, 2026 03:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limit_by_batch_size_flagondontime.Observationwas always set totrueand never read.Outcome()already trimsObservedDonTimesto batch size unconditionally.[deprecated = true]in the proto instead of removing it (alternative to Remove obsolete limit_by_batch_size_flag from dontime #2447, per review feedback). Regenerateddontime.pb.go.Deployment Validation
Outcome doesn't read the flag in any env. Confirm no non-determinism warnings during rollout.
🤖 Generated with Claude Code