Repository navigation
Wire batch buffer limit (1GB) into durable emitter - #2538
Open
DylanTinianov wants to merge 1 commit into
Open
DylanTinianov wants to merge 1 commit into
DylanTinianov wants to merge 1 commit into
Conversation
Contributor
✅ API Diff Results -
|
DylanTinianov
marked this pull request as ready for review
November 6, 2026 16:06
DylanTinianov
changed the title
| chipingressbatch.WithBatchInterval(defaultDuration(cfg.BatchInterval, 50*time.Millisecond)), | ||
| chipingressbatch.WithMaxConcurrentSends(defaultInt(cfg.MaxConcurrentSends, 4)), | ||
| chipingressbatch.WithMessageBuffer(defaultInt(cfg.MessageBufferSize, 10_000)), | ||
| chipingressbatch.WithMaxBufferedBytes(defaultInt64(cfg.MaxBufferedBytes, 1<<30)), |
Contributor
There was a problem hiding this comment.
Either add a comment here explaining this corresponds to a gigabyte or convert it to a var that makes it clear it is
eg 1024 * 1024 * 1024
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wires the chip ingress batch client's
WithMaxBufferedBytesopt into the durable emitter with a 1GB default.