Repository navigation
Remove data flags from remote pool policy - #2403
Merged
Merged
Conversation
matYang
marked this pull request as ready for review
November 7, 2026 16:01
matYang
commented
Nov 7, 2026
| PolicyConfig.Policies private s_remotePoolPolicies; | ||
| mapping(bytes32 policyName => mapping(uint64 remoteChainSelector => RemotePoolRecord record)) private | ||
| s_policyRemotePoolRecords; | ||
| mapping(bytes32 policyName => mapping(uint64 remoteChainSelector => EnumerableSet.Bytes32Set remotePoolHashes)) |
Collaborator
Author
There was a problem hiding this comment.
remote pool policy just use hash set
0xsuryansh
previously approved these changes
Nov 7, 2026
0xsuryansh
previously approved these changes
Nov 8, 2026
matYang
enabled auto-merge
November 8, 2026 10:36
|
0xsuryansh
approved these changes
Nov 8, 2026
chris-de-leon-cll
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flags are never used in the policy, they are now enforced to be always false because remote pool policies assume remote to be MTTP exclusively.
They were there from the beginning, then kept to be consistent with inline records after our decision that remote pool policy will assume remote to be MTTP.