Fix setting port on a dedicated server with the SERVER_PORT variable not working when using the docker#1457
Merged
sylvessa merged 1 commit intosmartcmd:mainfrom Apr 2, 2026
Merged
Conversation
…RT variable in yml files
BrainFart17
changed the title
BrainFart17
changed the title
Collaborator
|
ty for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes it so that setting SERVER_PORT when using the docker works correctly
Changes
Replaces instances of the hard coded default port (25565) in the yml files used for the docker with the SERVER_PORT variable
Previous Behavior
Previously, changing the SERVER_PORT variable wouldn't work correctly since the default port of 25565 was still hard-coded in the ports.
Root Cause
The mismatch between the hard-coded port and the port set by SERVER_PORT caused dedicated servers to not work when SERVER_PORT was set to something other than 25565
New Behavior
Setting SERVER_PORT now works as intended
Fix Implementation
replaced instances of 25565 with $SERVER_PORT
AI Use Disclosure
None
Related Issues
None