React: conditionally render passkey method based on platform support#223
Open
jake-slashid wants to merge 5 commits intomainfrom
Open
React: conditionally render passkey method based on platform support#223jake-slashid wants to merge 5 commits intomainfrom
jake-slashid wants to merge 5 commits intomainfrom
Conversation
Deploying with
|
| Latest commit: |
c92fbb1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9a43ffdc.website-react-storybook.pages.dev |
| Branch Preview URL: | https://passkey-detect.website-react-storybook.pages.dev |
kaspermroz
approved these changes
Mar 4, 2024
ikovic
reviewed
Mar 4, 2024
| @@ -0,0 +1,3 @@ | |||
| import { Utils } from "@slashid/slashid"; | |||
|
|
|||
| export const runtimeSupportsPasskeys = Utils.runtimeSupportsBestPasskeyUX(); | |||
Collaborator
There was a problem hiding this comment.
This might cause trouble if executed server side. Can we make sure this either runs client side only or gets parametrised so the user agent string is passed in? Server side we can read it from the HTTP request.
Contributor
Author
There was a problem hiding this comment.
I totally agree, I will need some help from you to consider SSR edge-cases since you're most familiar with the things we've previously delivered in this space.
ikovic
reviewed
Mar 4, 2024
|
|
||
| const passkeySupportDetectionLoading = showPasskeys === null; | ||
| if (passkeySupportDetectionLoading) { | ||
| return null; |
Collaborator
There was a problem hiding this comment.
Ideally this would be a skeleton or some sort of placeholder, so we can avoid layout shifts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding passkey support detection to the auth method selector in
<Form>This PR is just barely working, full of debugs and in need of some TLC.
Coming soon!