-
Notifications
You must be signed in to change notification settings - Fork 14
feat: include status loading messages and more feedback blocks #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat-ai-apps-thinking-steps
Are you sure you want to change the base?
Conversation
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Leaving a note of changes found between reviewsets-
| # Add a pause between rolls to demonstrate loading states | ||
| time.sleep(2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⌛ note: I'd be in favor of returning this to both samples to mirror a slower tool call for demonstration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also prefer the slower tool call for the demo. When it moves quickly, I'm left feeling like I wasn't able to follow the state changes.
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Thanks for aligning this sample with Node JS! 🙇🏻
| # Add a pause between rolls to demonstrate loading states | ||
| time.sleep(2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also prefer the slower tool call for the demo. When it moves quickly, I'm left feeling like I wasn't able to follow the state changes.
Type of change
Summary
This PR matches changes made during review of slack-samples/bolt-js-assistant-template#98
Requirements