Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jan 30, 2026

Type of change

  • New feature

Summary

This PR matches changes made during review of slack-samples/bolt-js-assistant-template#98

Requirements

  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@zimeg zimeg self-assigned this Jan 30, 2026
@zimeg zimeg added audit Changes associated with auditing documentation Improvements or additions to documentation enhancement New feature or request labels Jan 30, 2026
Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Leaving a note of changes found between reviewsets-

Comment on lines -26 to -27
# Add a pause between rolls to demonstrate loading states
time.sleep(2)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⌛ note: I'd be in favor of returning this to both samples to mirror a slower tool call for demonstration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer the slower tool call for the demo. When it moves quickly, I'm left feeling like I wasn't able to follow the state changes.

@zimeg zimeg requested review from mwbrooks and srtaalej January 30, 2026 04:33
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks for aligning this sample with Node JS! 🙇🏻

Comment on lines -26 to -27
# Add a pause between rolls to demonstrate loading states
time.sleep(2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer the slower tool call for the demo. When it moves quickly, I'm left feeling like I wasn't able to follow the state changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit Changes associated with auditing documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants