Add pprof flags to all long-running dmsg services#350
Merged
0pcom merged 4 commits intoskycoin:developfrom Mar 25, 2026
Merged
Conversation
Add --pprofmode and --pprofaddr flags matching the skywire visor pattern to dmsg-server, dmsg-discovery, dmsgweb, dmsgpty-host, dmsghttp, and dmsg-socks5. Extract shared pprof utility to pkg/cmdutil/pprof.go to eliminate duplication. Supports cpu, mem, mutex, block, trace, and http profiling modes.
go-toml/v2 v2.2.4 -> v2.3.0 skycoin v0.28.5-alpha1 -> v0.28.5
Fix nakedret and gosec G104 violations by using explicit returns and handling file close errors.
Update github.com/skycoin/skycoin to f48988877c68c8f92773008b6d73ce7f6f357d1e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --pprofmode and --pprofaddr flags matching the skywire visor pattern to dmsg-server, dmsg-discovery, dmsgweb, dmsgpty-host, dmsghttp, and dmsg-socks5. Extract shared pprof utility to pkg/cmdutil/pprof.go to eliminate duplication. Supports cpu, mem, mutex, block, trace, and http profiling modes.