fix ilk debt ceiling global sync and skip drip on onboarding#106
Open
mooncitydev wants to merge 1 commit into
Open
fix ilk debt ceiling global sync and skip drip on onboarding#106mooncitydev wants to merge 1 commit into
mooncitydev wants to merge 1 commit into
Conversation
add optional global line sync when setting an ilk debt ceiling, and skip jug drip when setting stability fee on a newly onboarded ilk.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey team, moondev here. was poking at spell helpers and landed two fixes tied to open issues #69 and #70.
first,
setIlkDebtCeilingcould set an ilk line without touching globalLine. that bites when you zero out an ilk dc but global stays inflated, or when you want one call to keep them aligned. added an optional_globalflag that bumps global by the delta (same idea as increase/decrease ilk helpers).addNewCollateralnow uses that instead of separate increase + set calls.second,
addNewCollateralwas callingsetIlkStabilityFeewith drip enabled right afterjug.init. nothing to accrue yet, just extra gas and a pointless drip on a fresh ilk. flipped that tofalse.added tests for the global sync path and zeroing an ilk line.
forge buildis clean on my side; fork tests still wantETH_RPC_URLfor mainnet.closes #69
closes #70