Skip to content

fix ilk debt ceiling global sync and skip drip on onboarding#106

Open
mooncitydev wants to merge 1 commit into
sky-ecosystem:masterfrom
mooncitydev:fix-debt-ceiling-and-onboarding-drip
Open

fix ilk debt ceiling global sync and skip drip on onboarding#106
mooncitydev wants to merge 1 commit into
sky-ecosystem:masterfrom
mooncitydev:fix-debt-ceiling-and-onboarding-drip

Conversation

@mooncitydev

Copy link
Copy Markdown

hey team, moondev here. was poking at spell helpers and landed two fixes tied to open issues #69 and #70.

first, setIlkDebtCeiling could set an ilk line without touching global Line. that bites when you zero out an ilk dc but global stays inflated, or when you want one call to keep them aligned. added an optional _global flag that bumps global by the delta (same idea as increase/decrease ilk helpers). addNewCollateral now uses that instead of separate increase + set calls.

second, addNewCollateral was calling setIlkStabilityFee with drip enabled right after jug.init. nothing to accrue yet, just extra gas and a pointless drip on a fresh ilk. flipped that to false.

added tests for the global sync path and zeroing an ilk line. forge build is clean on my side; fork tests still want ETH_RPC_URL for mainnet.

closes #69
closes #70

add optional global line sync when setting an ilk debt ceiling, and skip
jug drip when setting stability fee on a newly onboarded ilk.
@DaiFoundation-DevOps

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No need to drip when a collateral was just onboarded Option to adjust global DC with setIlkDebtCeiling

2 participants