Add StarGuard plot/drop helpers#105
Merged
Merged
Conversation
riccardopersiani
self-requested a review
April 30, 2026 09:26
riccardopersiani
left a comment
Member
There was a problem hiding this comment.
The tests covers every line.
The size is slightly higher than reported but still safe.
riccardopersiani
previously approved these changes
May 4, 2026
amusingaxl
reviewed
May 15, 2026
riccardopersiani
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
DssExecLibwrappers forStarGuard.plotandStarGuard.drop, enabling Core spells to whitelist a Star Spell for permissionless execution (and revoke it) without inlining the call.Changes
src/DssExecLib.solStarGuardLikeinterface.plotStarSpell(address _starGuard, address _starSpell, bytes32 _starSpellTag)— whitelists a Star Spell by codehash.dropStarSpell(address _starGuard)— clears the currently whitelisted Star Spell.executeStarSpell(starProxy, starSpell)shape.src/mocks/MockStarGuard.sol— new mock withplot/droprecorders and ashouldFailtoggle.src/mocks/MockDssSpellAction.sol—plotStarSpell_test/dropStarSpell_testwrappers.src/DssAction.t.sol— 5 tests: plot success, plot overwrite, plot failure, drop success, drop failure.README.md— documents the two new helpers in the SubDAO/Star Spells section.Verification
DssExecLibruntime size: 18,549 / 24,576 bytes — well under the EIP-170 limit, so both helpers fit comfortably.