Add check port support - #231
Open
kenichi-mashiyama wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for configuring a dedicated health check port (
check port <number>) for servers across backends and listens.Motivation
Currently, when health checks are enabled, HAProxy Operator defaults to using the same port as the server's traffic port for health checks. However, some applications expose a separate, dedicated port for health checks or metrics (e.g., application traffic on port 8080, but health checks on port 80). By adding the
portfield to theCheckstruct, users can now explicitly specify a different port for health checks directly through the CRDs.Changes
Port(*int64) field with validation (min: 1, max: 65535) to theCheckstruct inapis/config/v1alpha1/common_types.go.Model()methods forServerandServerTemplateto map this new field to the native HAProxy model (model.HealthCheckPort).apis/config/v1alpha1/backend_types_test.goto verify the correct generation of thecheck port <number>configuration on the server line.Checklist