fix(web): improve mouse input reliability - #140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves remote mouse reliability across connection changes, input-mode transitions, and browser lifecycle events.
Mouse button state is now released consistently when the WebSocket disconnects, the page loses focus or visibility, pointer lock ends, touch input is interrupted, or the user switches mouse modes. Failed release reports are retained and replayed after reconnection so that a transient connection loss does not leave a button pressed on the target host.
The change also tightens absolute-coordinate handling at display boundaries and removes an unnecessary reconnect when changing mouse modes.
Changes
Verification
pnpm install --frozen-lockfilepnpm run buildgit diff --checkManual Testing
Test topology: Microsoft Edge on an Android tablet as the Web client, with a Windows PC as the controlled host.