Skip to content

No delete others communications#569

Open
LeoPlix wants to merge 6 commits intomasterfrom
No_Delete_Others_Communications
Open

No delete others communications#569
LeoPlix wants to merge 6 commits intomasterfrom
No_Delete_Others_Communications

Conversation

@LeoPlix
Copy link
Copy Markdown

@LeoPlix LeoPlix commented Apr 6, 2026

No description provided.

if (isCoordinator.value) return true;
if (isAdmin.value) return true;

return Boolean(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use Boolean(...)?

Comment thread yarn.lock Outdated
@@ -0,0 +1,170 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

}

if credentials.Role.AccessLevel() != 0 && p.Member != credentials.ID {
if credentials.Role.AccessLevel() > 1 && p.Member != credentials.ID {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change necessary?

Copy link
Copy Markdown
Author

@LeoPlix LeoPlix Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, from what I gathered admin has access level 0 and coordinators have access level 1, so it was the only way to garantee access to edit to both roles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants