Repository navigation
Optimize Value.Convert property matching (up to 2.9x faster on object arrays) - #1740
Open
deadstrobe5 wants to merge 1 commit into
Open
deadstrobe5 wants to merge 1 commit into
deadstrobe5 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value.Convertmatched object properties by building aRegExp(^key$) for each property on every call and testing it against every key of the value. This changes it to look each property key up in aSetof the value's own keys, the same wayValue.Defaultalready does. TheadditionalPropertiesbranch still gets the same regex entries as before.This also fixes keys with regex characters in them. Before, a property named
$idwas never converted (the$ends the pattern),a.balso converted a siblingaxb, andd(threwInvalid regular expression. I added a test for these intest/typebox/runtime/value/convert/object.ts.Value.ConvertMeasured on Node 24 (Ryzen 5 5600X) with the old and new source loaded in the same process, 9 alternating rounds, medians. An empty object is unchanged. I also ran old and new side by side over 90,000 random schemas and values (nested objects, optional properties, unions, intersects, records,
additionalProperties) and the output was identical.npm testpasses.