[Monk] Balanced Stratagem, Counterstrike#10934
Merged
renanthera merged 5 commits intosimulationcraft:midnightfrom Feb 21, 2026
Merged
[Monk] Balanced Stratagem, Counterstrike#10934renanthera merged 5 commits intosimulationcraft:midnightfrom
renanthera merged 5 commits intosimulationcraft:midnightfrom
Conversation
Contributor
justindriggers
commented
Feb 13, 2026
justindriggers
commented
- Exploding Keg travel time is not represented by missile_speed()
- Initial Exploding Keg damage is not affected by Balanced Stratagem, but is consumed on cast and affects the following proc hits
- Simplify Rushing Jade Wind
- Snapshot Balanced Stratagem for BoF, SCK, RJW, CJL, EK
- Snapshot Counterstrike for SCK
- Jade Flash is not affected by Balanced Stratagem
- Defer Balanced Stratagem consumption for Chi Burst until the damage and heal have executed
renanthera
force-pushed
the
65867-balanced_stratagem
branch
from
fefbe1c to
fa37bda
Compare
* Exploding Keg travel time is not represented by missile_speed() * Initial Exploding Keg damage is not affected by Balanced Stratagem, but is consumed on cast and affects the following proc hits * Simplify Rushing Jade Wind * Snapshot Balanced Stratagem for BoF, SCK, RJW, CJL, EK * Snapshot Counterstrike for SCK * Jade Flash is not affected by Balanced Stratagem * Defer Balanced Stratagem consumption for Chi Burst until the damage and heal have executed
…rride. Fix counterstrike parsed value. Lambda capture by reference. Use `buff_t::expire` instead of `buff_t::consume`, as SCK ticks fail consume check.
renanthera
force-pushed
the
65867-balanced_stratagem
branch
from
60054b3 to
852fa64
Compare
renanthera
merged commit 6c40994
into
simulationcraft:midnight
173 of 225 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.