Conversation
Contributor
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
tombogle
force-pushed
the
update-dependencies
branch
from
September 11, 2026 22:01
f4c92b6 to
3bd77a7
Compare
Contributor
Author
|
Previously, imnasnainaec (D. Ror.) wrote…
Done |
…rabilities Upgrades L10NSharp/L10NSharp.Windows.Forms to 11.0.0 and SIL.BuildTasks to 3.3.0, plus the System.Memory/System.Resources.Extensions/FFMpegCore/icu.net version alignment needed to keep restore consistent across the solution. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ins.Annotations, NUnit, System.Configuration.ConfigurationManager, System.Resources.Extensions, and a netstandard2.0-only SIL.ReleaseTasks/Markdig.Signed bump SIL.ReleaseTasks 3.3.0 pulls in Microsoft.Build.Tasks.Core, which has no net462/net48 asset and disrupts implicit WindowsBase/System.IO.Packaging resolution when consumed via its netstandard2.0 fallback there, so it's split per-TFM: netstandard2.0-targeting projects get 3.3.0 (and the Markdig.Signed 0.41.1 floor it requires), net462/net48 stay on 3.1.1/0.37.0. net8.0-windows projects that transitively consume the netstandard2.0 build of SIL.Core/SIL.WritingSystems get the same Markdig.Signed bump to match. Also adds unit test coverage for two previously-untested code paths this touches: Markdig rendering in ShowReleaseNotesDialog, and the ConfigurationManager-backed FactoryPassword fallback in SettingsProtectionSingleton. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…xtensions version and a stale hardcoded NUnit copyright-year assertion SIL.Scripture.Tests still had System.Resources.Extensions pinned at 6.0.0, which conflicted at runtime with the 10.0.12 pulled in transitively via SIL.Windows.Forms.Scripture.Tests's other references, causing a FileLoadException on net48 (assembly manifest mismatch between the two resolved versions). Bumped it to 10.0.12 to match the rest of the graph. AcknowledgementAttributeTests.CreateAnAcknowledgement_NoCopyright_OverriddenByFile hardcoded NUnit's embedded copyright year, which changed for real between 3.13.3 and 3.14.0. Reworked it (and its NoName sibling) to compare against FileVersionInfo read directly from the DLL, so they test the actual behavior instead of a value that goes stale on every future NUnit bump. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…t NUnit's Comparing against FileVersionInfo read live from the DLL (the previous fix) sidesteps breaking on every NUnit bump, but does so by computing the expected value the same way the production code does, which is less obvious to read and weaker at catching a real regression in AcknowledgementAttribute itself. Pointing at this test assembly instead restores a literal, readable expected value (its Copyright/ProductName come from Directory.Build.props, which we only change deliberately) while still being immune to third-party dependency churn. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…nt range
The exact end year in Directory.Build.props's <Copyright> gets bumped
annually, so hardcoding it meant the test would need editing on the same
cadence. Keep the fixed text ("Copyright © 2010-...SIL Global") asserted
exactly, but accept any year within the last 3 (and not in the future),
so routine annual bumps don't require a matching test change while a
genuinely stale or mistyped year still fails.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tombogle
force-pushed
the
update-dependencies
branch
from
September 14, 2026 12:57
a0ad33f to
d262924
Compare
tombogle
marked this pull request as draft
September 14, 2026 13:48
Contributor
Author
|
DRAFT: Worth considering waiting for sillsdev/SIL.BuildTasks#90 and getting a new release through the ranks in order to simplify this PR. |
Upgraded test app to use latest localized strings
Added required explicit reference to System.Memory 4.6.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades L10NSharp/L10NSharp.Windows.Forms to 11.0.0 and SIL.BuildTasks to 3.3.0, plus the System.Memory/System.Resources.Extensions/FFMpegCore/icu.net version alignment needed to keep restore consistent across the solution.
This change is