Offline langs - #4361
Draft
imnasnainaec wants to merge 7 commits into
Draft
Offline langs#4361imnasnainaec wants to merge 7 commits into
imnasnainaec wants to merge 7 commits into
Conversation
Quote every expansion subject to word splitting or globbing. The three
variables that deliberately hold several words become arrays, since
quoting them as strings would collapse each into a single argument.
Replace the remaining backticks with $(...) so that the file uses one
command-substitution style throughout.
No behavior change. The argument lists built for setup_cluster.py,
setup_combine.py and ansible-playbook are identical before and after,
including the case where no options are set and no arguments are passed.
"echo ${combine_status}" in wait-for-combine stays unquoted; quoting it
would change which line the loop reads, so it needs its own fix.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
documentation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is