Fix attester/PTC duty cache labeling on probe and bulk refresh - #10094
Open
NikhilSharmaWe wants to merge 2 commits into
Open
NikhilSharmaWe wants to merge 2 commits into
NikhilSharmaWe wants to merge 2 commits into
Conversation
Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
michaelsproul
left a comment
michaelsproul
left a comment
Member
There was a problem hiding this comment.
feasible to add a regression test for this?
Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
Author
|
Added a small unit test around a |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attester (and PTC) duty polling probes a small validator set for the
dependent_root, then optionally fetches the rest. Those two calls can observe different dependent roots (fallback BN or re-org between requests). Bulk duties were stored under the probe root, so the next poll's staleness check could skip refresh and keep the wrong duties.When a second fetch is needed, fetch all validators that need updating in one request and store only that response's
(dependent_root, data). Same for PTC.Fixes #10091
Test plan
cargo check -p validator_servicescargo nextest run -p validator_services