Include slashed balances in fork choice committee fraction

[NikhilSharmaWe]

Description

calculate_committee_fraction used total_effective_balance, which excludes active slashed validators. Spec get_total_active_balance includes them.

Use JustifiedBalances::total_active_balance() (unslashed + slashed_balances) in that helper. Attestation balances remain zero for slashings.

Closes #10057

Test plan

• cargo nextest run -p proto_array justified_balances
• cargo nextest run -p fork_choice --release

[eserilev]

can you add a regression test asserting justified_balances.total_active_balance() matches state.get_total_active_balance()

We have a helper check_justified_balances in fork_choice/tests/test.rs, I think you can throw the assert in there

[NikhilSharmaWe]

can you add a regression test asserting justified_balances.total_active_balance() matches state.get_total_active_balance()

We have a helper check_justified_balances in fork_choice/tests/test.rs, I think you can throw the assert in there

added the assert in check_justified_balances against state.get_total_active_balance()