Skip to content

refactor(split): migrate to Angular output function#2275

Open
spliffone wants to merge 1 commit into
mainfrom
refactor/split-migrate-to-output-function
Open

refactor(split): migrate to Angular output function#2275
spliffone wants to merge 1 commit into
mainfrom
refactor/split-migrate-to-output-function

Conversation

@spliffone

@spliffone spliffone commented Jul 3, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@spliffone spliffone requested review from a team as code owners July 3, 2026 11:05
@spliffone spliffone added the breaking-changes Marks issues and PRs that are breaking the API label Jul 3, 2026
@spliffone spliffone added this to the 51.0.0 milestone Jul 3, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 3, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the split component (SiSplitComponent and SiSplitPartComponent) to use Angular's modern output() function instead of the legacy @output() decorator and EventEmitter, which aligns with the repository's style guide. The corresponding API golden file has also been updated to reflect these changes. I have no feedback to provide as the changes are correct and follow best practices.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@spliffone spliffone force-pushed the refactor/split-migrate-to-output-function branch from 95e0007 to 8ed6fbc Compare July 3, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

breaking-changes Marks issues and PRs that are breaking the API

Projects

None yet

Milestone

51.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@spliffone