feat(map-styles): introduce new library '@siemens/map-styles'#2080
Open
spliffone wants to merge 1 commit into
Open
feat(map-styles): introduce new library '@siemens/map-styles'#2080spliffone wants to merge 1 commit into
spliffone wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new library, @siemens/maps-theme, which provides Siemens-branded map styles for MapLibre GL and includes Angular signals for reactive theme switching. The changes also migrate existing styling logic from the maps-ng component to this shared library. Feedback focuses on improving the monorepo developer experience by pointing path mappings to source files instead of build artifacts, correctly categorizing maplibre-gl as a peer dependency, and ensuring the library's public entry point serves as a pure re-export barrel.
spliffone
force-pushed
the
feat/introduce-maps-theme-library
branch
4 times, most recently
from
2aaae20 to
41d260a
Compare
dr-itz
reviewed
May 19, 2026
spliffone
force-pushed
the
feat/introduce-maps-theme-library
branch
from
e8fca22 to
da70979
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
spliffone
force-pushed
the
feat/introduce-maps-theme-library
branch
from
da70979 to
a69d626
Compare
dr-itz
reviewed
May 20, 2026
spliffone
force-pushed
the
feat/introduce-maps-theme-library
branch
4 times, most recently
from
77b089b to
add28c5
Compare
Member
Author
|
@kfenner Please have a look I am a bit concerned that we use a peerDependency in maps instead of a real dependency. |
spliffone
changed the title
spliffone
force-pushed
the
feat/introduce-maps-theme-library
branch
from
add28c5 to
7d178f8
Compare
chintankavathia
requested changes
May 27, 2026
spliffone
force-pushed
the
feat/introduce-maps-theme-library
branch
2 times, most recently
from
b5aede4 to
79a22c0
Compare
kfenner
reviewed
May 27, 2026
spliffone
force-pushed
the
feat/introduce-maps-theme-library
branch
from
17936da to
32b0907
Compare
Member
|
@spliffone Let's wait with this. We had more discussions with @spike-rabbit - we might do it for v51 then so we have more time to test stuff out. |
spliffone
force-pushed
the
feat/introduce-maps-theme-library
branch
from
32b0907 to
eb05d4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a reusable map theme library to share the map style.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: