fix(breadcrumb): add space key activation to dropdown toggle#2061
Open
akashsonune wants to merge 1 commit into
Open
fix(breadcrumb): add space key activation to dropdown toggle#2061akashsonune wants to merge 1 commit into
akashsonune wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a space key event listener to the breadcrumb component to improve accessibility. The reviewer suggested refactoring the inline logic into a dedicated component method to adhere to the project's style guide, which discourages complex logic within templates.
Member
|
@akashsonune needs rebasing |
akashsonune
force-pushed
the
fix/a11y-breadcrumb-space-key-activation
branch
2 times, most recently
from
82c15d9 to
c9643cd
Compare
spike-rabbit
requested changes
Jun 11, 2026
akashsonune
force-pushed
the
fix/a11y-breadcrumb-space-key-activation
branch
from
c9643cd to
018872f
Compare
spike-rabbit
requested changes
Jun 11, 2026
| padding: 0; | ||
| border: 0; | ||
| background: none; | ||
| cursor: pointer; |
Member
There was a problem hiding this comment.
Please try to remove this entire class and just btn btn-link
akashsonune
force-pushed
the
fix/a11y-breadcrumb-space-key-activation
branch
from
018872f to
202ecee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: