Sh vtol dev#10
Open
shota3527 wants to merge 44 commits into
Open
Conversation
This reverts commit 49e69f0.
update documents
shota3527
force-pushed
the
sh_vtol_dev
branch
from
1e1383a to
7556e6a
Compare
sensei-hacker
pushed a commit
that referenced
this pull request
May 30, 2026
The CAN1 RX0 interrupt was being enabled at the beginning of the dronecanSTM32CAN1_Init() function, before all hardware initialization steps were complete. If any subsequent initialization step failed (HAL_CAN_Init, HAL_CAN_ConfigFilter, or HAL_CAN_Receive_IT), the function would return an error while the interrupt remained enabled. This created a race condition where spurious interrupts could fire on unconfigured hardware, causing crashes or undefined behavior. Move the interrupt enable to the end of the function, after all initialization succeeds. If any step fails, the function returns early without enabling the interrupt, preventing spurious ISR calls. This ensures safe failure handling and prevents system crashes from incomplete hardware initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.