Additional holidays and holiday fix for Australia#10
Open
arguellesjonas wants to merge 12 commits into
Open
Conversation
arguellesjonas
changed the title
NT / Darwin
Sunday 20 April - Easter Sunday
Monday 4 August - Picnic Day
Queensland / Brisbane
Sunday 20 April - Easter Sunday
South Australia / Adelaide
Sunday 20 April - Easter Sunday
Friday 25 April <= this date is listed twice
Western Australia / Perth
Sunday 20 April - Easter Sunday
Fri - 25 Apr 2025 <= this date is listed twice
arguellesjonas
force-pushed
the
holidays-april-16-2025
branch
from
5066525 to
0bc5912
Compare
kcsuyog
reviewed
Apr 16, 2025
| regions: [au] | ||
| mday: 25 | ||
| - name: Easter Sunday | ||
| regions: [au_nt, au_qld, au_sa, au_wa] |
There was a problem hiding this comment.
@arguellesjonas can you confirm we are not suposed to add easter sunday for nsw?
There was a problem hiding this comment.
with method saying , enable this from 2025
There was a problem hiding this comment.
0
- name: Easter Sunday
regions: [au_nt, au_qld, au_sa, au_wa]
function: easter_from_2025
- easter_from_2025:
arguments: year
source: |
if year >=2025
easter(date)
end
There was a problem hiding this comment.
4:
- name: Easter Sunday
regions: [au_nt, au_qld, au_sa, au_wa]
function: easter_sunday_for_2025
kcsuyog
reviewed
Apr 16, 2025
| mday: 25 | ||
| - name: Easter Sunday | ||
| regions: [au_nt, au_qld, au_sa, au_wa] | ||
| mday: 20 |
kcsuyog
reviewed
Apr 16, 2025
| regions: [au_qld_brisbane] | ||
| week: -3 | ||
| wday: 3 | ||
| - name: Picnic Day |
There was a problem hiding this comment.
needs to have a function to enable this from 2025 onwards
arguellesjonas
force-pushed
the
holidays-april-16-2025
branch
from
f4270c4 to
454c790
Compare
arguellesjonas
force-pushed
the
holidays-april-16-2025
branch
from
1806e8a to
6f57f45
Compare
djstozza
approved these changes
Apr 16, 2025
kcsuyog
reviewed
Apr 16, 2025
| arguments: year | ||
| source: | | ||
| if year >= 2025 | ||
| DateCalculatorFactory::Easter::Gregorian.easter_calculator.calculate_easter_for(year) |
kcsuyog
approved these changes
Apr 16, 2025
Fix Ruby 3.1+ Date#to_s deprecation warning in ProcResultCache
ANZAC Day falls on Saturday April 25, 2026. NSW has announced Monday April 27 as an additional public holiday for 2026 only.
ANZAC Day falls on Sunday April 25, 2027. NSW observes Monday April 26 as an additional public holiday.
Add ANZAC Day 2026 observed holiday for NSW (April 27)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.