feat: add PTY nudge scheduling and notifications - #58
Closed
cybe42 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature summary
implements periodic agent nudges for long-running PTY sessions, addressing my previous #51.
nudges allow the agent to periodically check background processes that may be stalled, waiting for input, or taking longer than expected.
Before submitting this draft pull request I personally used this specific fork I made for 3 weeks+, almost every model I have used with the nudge fork has understood and utilised the feature to its full extent to work over long horizons, MOST NOTABLY; this fork has helped my agents stop wasting time. Instead of aimlessly waiting for commands to finish/pty instances to exit and/or setting insanely large timeouts and sitting doing nothing, this fork has made them more optimise their own time better while still being efficient. It has worked well for me in that regard and I still use this fork today.
feature
pty_nudgetool the model can specify its own nudge mode and also it's own interval vianudgeIntervalSeconds, it can set mode back to the automatic, it can set a one-time setting or it can even pause and resume nudges./stopnudgespauses all active nudges for the current chat, and shows a toast notificationEXAMPLE
nudge format
code is verified working, unit tests etc.
feedback welcome
this is an initial implementation, I'm not certain and cannot be certain if this draft pr meets the expected code requirements henceforth why I labeled it as Draft, and i’d appreciate a review and a feedback on the overall design and behavior, including code.
in particular, feedback on the automatic cadence, idle-session gating, and
/stopnudgesbehavior would be useful. i’m open to adjusting the API, defaults, or notification format based on review.