When done pass the callback() instead of next(). #517
Open
maxfortun wants to merge 1 commit intoshare:masterfrom
Open
When done pass the callback() instead of next(). #517maxfortun wants to merge 1 commit intoshare:masterfrom
maxfortun wants to merge 1 commit intoshare:masterfrom
Conversation
maxfortun
added a commit
to maxfortun/sharedb
that referenced
this pull request
Sep 14, 2021
alecgibson
reviewed
Sep 21, 2021
| var fn = fns.shift(); | ||
| if (!fn) return callback(); | ||
| fn(request, next); | ||
| fn(request, callback); |
Collaborator
There was a problem hiding this comment.
I'm not entirely sure this is correct. For starters, the tests don't pass.
Secondly, I think you'll find that passing callback like this will only ever call the first registered middleware, since we need to recursively call next() to keep pulling middlewares off the stack.
Can you build a test case that fails without this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [#484]