Skip to content

Move unit tests behind the public API boundary - #468

Closed
ANONYMOUSZED-beep wants to merge 1 commit into
servo:v2from
ANONYMOUSZED-beep:test/integration-suite
Closed

Move unit tests behind the public API boundary#468
ANONYMOUSZED-beep wants to merge 1 commit into
servo:v2from
ANONYMOUSZED-beep:test/integration-suite

Conversation

@ANONYMOUSZED-beep

Copy link
Copy Markdown

Summary

  • move the main test suite from src/tests.rs to tests/smallvec.rs
  • update imports to consume smallvec through its public API
  • preserve feature-gated coverage for std, serde, and bytes

This makes API export regressions visible to the test suite instead of compiling the tests as an internal crate module.

Closes #440

Validation

  • cargo +1.83.0-x86_64-pc-windows-gnu test (67 integration tests and 6 doctests passed)
  • cargo +stable-x86_64-pc-windows-gnu test (67 integration tests and 6 doctests passed)
  • cargo +nightly-x86_64-pc-windows-gnu fmt --all --check
  • cargo +nightly-x86_64-pc-windows-gnu test --all-features (78 integration tests and 6 doctests passed)
  • cargo +nightly-x86_64-pc-windows-gnu bench --all-features --no-run
  • git diff --check

@jdm

jdm commented Aug 28, 2026

Copy link
Copy Markdown
Member

@ANONYMOUSZED-beep Did you use AI tooling to create this pull request?

@alejandro-vaz

Copy link
Copy Markdown
Collaborator

@jdm I can't tell to be honest, it's 20 LOC, but the PR message is very generic

I think we should just let it pass unless it's obvious, otherwise we're going to go crazy

please merge #462 and this should be mostly solved

@alejandro-vaz
alejandro-vaz self-requested a review August 28, 2026 16:26

@alejandro-vaz alejandro-vaz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm withholding this PR for a while, it will introduce merge conflicts with #387 #458 #461

@ANONYMOUSZED-beep

Copy link
Copy Markdown
Author

Yes. I used AI-assisted development tooling to help prepare this pull request, and I reviewed the resulting changes before submitting it. I’m happy to provide any additional detail needed under the project’s contribution policy.

@jdm

jdm commented Aug 28, 2026

Copy link
Copy Markdown
Member

Sorry, we have a policy that does not allow that: https://book.servo.org/contributing/getting-started.html#ai-contributions

@jdm jdm closed this Aug 28, 2026
@jdm

jdm commented Aug 28, 2026

Copy link
Copy Markdown
Member

but the PR message is very generic

That's what I was reacting to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add integration tests

3 participants