fix: skip registry sync when a specific package is requested#22
Open
yashas-hm wants to merge 1 commit into
Open
fix: skip registry sync when a specific package is requested#22yashas-hm wants to merge 1 commit into
yashas-hm wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills get <package>no longer clones or updates git registry repositories as a side-effect. Registry sync now only runs for an unfilteredskills get.Details
Previously,
RegistrySync.sync()was called unconditionally, cloning all configured registries (e.g. the Flutter and Serverpod repos) into.dart_tool/skills/repos/even when the user ranskills get jaspr. The registry skills were correctly filtered after cloning, but the cloning itself always happened, polluting the workspace with unrelated repos.The fix guards the sync call behind
if (packageNames == null), matching the intended semantics: a bareskills get(no args) fetches everything;skills get <package>only installs skills for that specific package without touching unrelated registries.Test plan
when installing a specific package then registries are not clonedverifies that a configured global registry is not cloned whenskills get dep_pkgis run anddep_pkghas its own Dart skills.when git is unavailable,when installing from global registry) continue to pass.dart test).Closes #5
Fixes #5