fix: example and reference fixes for extensions#1136
fix: example and reference fixes for extensions#1136ricardozanini merged 3 commits intoserverlessworkflow:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the extension examples and reference documentation to correctly represent extensions as an array rather than a map, addressing discrepancies identified in issue #1135.
- Changed extensions from
map[string, extension]toextension[]in the reference documentation - Updated the extension example in dsl.md to use array syntax
- Corrected the
beforeandafterproperty types frommap[string, task]totask[]in the extension reference
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dsl.md | Updated the extension example to use array syntax (with list item prefix -) instead of map syntax |
| dsl-reference.md | Updated the extensions type from map[string, extension] to extension[] and corrected before/after properties from map[string, task] to task[] |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ricardozanini
left a comment
There was a problem hiding this comment.
Looks like Copilot is useful. :)
@arminhammer can you take a look at the Copilot suggestions? The property indeed is named endpoint.
Signed-off-by: Armin Graf <arminhammer@gmail.com>
Signed-off-by: Armin Graf <arminhammer@gmail.com>
11ed234 to
eda3d57
Compare
Interesting! My change was ultimately a formatting change, but it caused Copilot to take another look and spot the latent error. Useful indeed. In any case, I fixed the issue and changed |
Please specify parts of this PR update:
Discussion or Issue link:
#1135
What this PR does:
This PR proposes some fixes to the extension example in dsl.md, as well as the extension reference section in dsl-reference.md. These fixes are designed to align the spec with the discrepancies addressed in #1135.
Additional information: