Skip to content

[NO-ISSUE] Minor adjustments to decorators #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjtirado merged 2 commits into from
Jan 20, 2026
+12 −9
Merged

[NO-ISSUE] Minor adjustments to decorators #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
868e236
Apply minor adjustments to decorators
mcruzdev Jan 19, 2026
663dddc
Apply code-style
mcruzdev Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions impl/core/src/main/java/io/serverlessworkflow/impl/events/EmittedEventDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@
import io.serverlessworkflow.impl.TaskContext;
import io.serverlessworkflow.impl.WorkflowContext;

/**
* Interface for decorating {@link CloudEventBuilder} objects.
*
* <p>Implementations should be loaded via ServiceLoader and are sorted by priority in ascending
* order (lower priority numbers executed first). Decorators are applied in sequence, where later
* decorators can override configurations set by earlier decorators.
*
* @see ServicePriority
*/
public interface EmittedEventDecorator extends ServicePriority {

void decorate(
Expand Down
5 changes: 2 additions & 3 deletions impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/HttpExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,10 @@ public CompletableFuture<WorkflowModel> apply(
Builder request = target.request();

for (RequestDecorator requestDecorator : requestDecorators) {
requestDecorator.decorate(request, workflow, taskContext, input);
requestDecorator.decorate(request, workflow, taskContext);
}

headersMap.ifPresent(
h -> h.apply(workflow, taskContext, input).forEach((k, v) -> request.header(k, v)));
headersMap.ifPresent(h -> h.apply(workflow, taskContext, input).forEach(request::header));
return CompletableFuture.supplyAsync(
() -> requestFunction.apply(request, uri, workflow, taskContext, input),
workflow.definition().application().executorService());
Expand Down
7 changes: 1 addition & 6 deletions impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/RequestDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import io.serverlessworkflow.impl.ServicePriority;
import io.serverlessworkflow.impl.TaskContext;
import io.serverlessworkflow.impl.WorkflowContext;
import io.serverlessworkflow.impl.WorkflowModel;
import jakarta.ws.rs.client.Invocation;

/**
Expand All @@ -38,11 +37,7 @@ public interface RequestDecorator extends ServicePriority {
* @param requestBuilder the request builder to decorate
* @param workflowContext the workflow context
* @param taskContext the task context
* @param workflowModel the input data
*/
void decorate(
Invocation.Builder requestBuilder,
WorkflowContext workflowContext,
TaskContext taskContext,
WorkflowModel workflowModel);
Invocation.Builder requestBuilder, WorkflowContext workflowContext, TaskContext taskContext);
}