Lint/CI gates, panic hardening, activate.profile, nullable schema#381
Merged
Conversation
Resolve all clippy warnings (io::Error::other, redundant field names, needless borrows, redundant closures) and annotate the few functions that legitimately take many arguments with #[allow(clippy::too_many_arguments)]. Add `clippy`, `rustfmt` and `reuse` derivations to the flake checks so they run in CI alongside the existing build. The reuse check surfaced two files missing SPDX headers (src/command.rs and the CI workflow); add them.
The activation waiter unwrapped oneshot channel results: a successful activation that finished before the wait command returned would resolve recv_activate with a RecvError and panic. Handle that case as success, and ignore send errors when the receiver is already gone. The flake-fragment parser unwrapped rnix AST nodes; malformed targets could panic instead of returning ParseFlakeError. Propagate the error.
A new activator alongside custom/nixos/home-manager/darwin/noop that installs the closure into the target user's `nix profile`, replacing a previous generation of the same name. The existing lib API is unchanged.
Sereja313
reviewed
Jun 16, 2026
| # into the calling user's `nix profile`, replacing a previous | ||
| # generation with the same name. Useful for declaratively rolling | ||
| # out a package (or a `buildEnv`) to a machine. | ||
| profile = base: custom base '' |
Member
There was a problem hiding this comment.
It would be nice to mention this activator in the README.
Sereja313
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A batch of small, non-breaking improvements. The public surface —
deploy-rs.lib.<system>.activate.*, theinterface.jsonconfig schema, thedeployCLI flags, and thedeploy↔activateprotocol — is unchanged.Commits
#[allow], and adds three lint derivations to the flakechecks(so they run in CI). Thereusecheck caught two pre-existing files missing SPDX headers (src/command.rs,.github/workflows/check.yml) — fixed.setActivate—examples/simplenow usesactivate.custom(the alias stays for back-compat).unwrap()ped a oneshotRecvError(a successful activation finishing before the wait command returned would panic); now handled as success. The rnix fragment parserunwrap()ped AST nodes; malformed targets now returnParseFlakeErrorinstead of panicking.activate.profile— a new additive activator that installs the closure into the target's nix3nix profile(idempotent: replaces a previous generation of the same name). Existing activators untouched.interface.json— widens the schema so optional settings may benull(backward-compatible; also future-proofs a module-system consumer that emits explicitnulldefaults).Verification
Run in a
nixos/nix(aarch64) container against a toy multi-node flake:nix build .#checks.<sys>.{clippy,rustfmt,reuse,deploy-rs}→ all passDeployment confirmed.(confirms the waiter fix doesn't regress the rollback path)activate.profile→ installs + runs a package, idempotent on re-deploydeploywith schema checks andfastConnection = null→ passes (exercises the nullable schema end-to-end)