Open
Conversation
bsonntag
requested review from
Joanata,
MicaelRodrigues,
catarinapeixoto and
franciscomorais
bsonntag
force-pushed
the
feature/rewrite-with-subscriptions
branch
from
ca4111e to
de39e39
Compare
added 2 commits
March 28, 2022 13:51
bsonntag
force-pushed
the
feature/rewrite-with-subscriptions
branch
from
de39e39 to
e0f22c8
Compare
| @@ -22,8 +22,9 @@ | |||
| "bundle": "rm -rf dist && babel src --out-dir dist", | |||
Contributor
There was a problem hiding this comment.
This should be changed to parcel right?
Contributor
Author
There was a problem hiding this comment.
No. Parcel is only used to bundle the example application. The module is still bundled using Babel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS
This PR adds a rewrite of the module that aims to improve performance of forms.
In this implementation, instead of storing the form state in a
useReducer, I'm storing it in auseRef. EachuseFieldthen usesuse-subscriptionto subscribe to changes to a field's state. With this, only the fields that need to be updated will be re-rendered, instead of the whole form.I tried to make the API change of the module as small as possible, so that this rewrite can be dropped-in in any application that is using
@seegno/react-formswithout much difficulty.I also took the opportunity of the rewrite to change the module to TypeScript.