Repository navigation
docs: align installation names and fix CI bootstrap - #132
poplolioi11 wants to merge 2 commits into
Conversation
|
The GitHub check currently reports This PR changes only the two installation code-block lines. The local Git naming reproduction, targeted Sphinx/MyST rendering, unchanged-gettext comparison and browser readback passed, as described above. I could not determine the filter failure's cause from the available GitHub summary, and have not changed the CI configuration or rerun the workflow. Could a maintainer please inspect that filter job when reviewing? Thank you. |
|
I traced the filter failure to its actual Set parameters log: the current The original blocker is now confirmed fixed on CircleCI: path-filtering job 5324 passes on that commit, and continuation succeeds. The subsequent build job 5325 and sfl-lite job 5339 stop before execution with |
The source-installation instructions use inconsistent directory and Conda environment names: cloning
sfl.gitcreatessfl, but the next command enterssecretflow; the environment is created assecretflowand activated assfl. Usecd sfland create thesflenvironment to make both sequences consistent.Fixes #131.
This PR also fixes the existing CircleCI path-filtering bootstrap failure encountered on the documentation change. Job 5323, at head
aca2e9c, fails in Set parameters before filtering or tests: the downloadedget-pip.pyrejects Python 3.9 and requires Python 3.10 or newer. Change only the filter job's image tag from3.9to3.11, which the existing orb supports and the project already lists as supported. The mappings, continuation configuration, test selection and application dependencies are unchanged.Validation:
c383e40: a local Git fixture reproduced the failingcd secretflowand passingcd sfl; Conda arguments agree, but Conda itself was not run.docs/update_po.shis absent on this main, so a targeted gettext check was used.get-pip.pyfails under native Python 3.9.6 with the error from CircleCI, and succeeds under Python 3.11.18 using an isolated user-package directory. Installingvirtualenvand creating a virtual environment also succeed under 3.11.git diff --checkpasses. The officialcimg/python:3.11tag is active for Linux amd64.The local bootstrap checks ran on macOS. After pushing
14a7374, CircleCI pipeline #320 successfully ran the actual Linux path-filtering job 5324, including bootstrap and continuation. The subsequent build and sfl-lite jobs 5325 and 5339 could not start: CircleCI reportsresource-class-not-in-planfor the configured Docker2xlarge+resource class. That separate project-resource issue remains for maintainers; application tests have not run. The complete SFL installation and full documentation-site build were not run locally.AI assisted the changes. An independent assistant statically reviewed the CI diagnosis; executable results above were produced by local commands, not by the reviewer.