fix(deviations): split monolithic test cases and fix partial-revert race#103
Merged
fix(deviations): split monolithic test cases and fix partial-revert race#103
Conversation
Contributor
steiler
commented
Apr 10, 2026
steiler
commented
- Refactor 22-srl-nonrevertive.robot and 21-sros-nonrevertive.robot: replace single intent-loop test cases with individual tagged test cases per intent, enabling per-intent execution and better failure isolation
- Fix race in Reset Intent Baseline For Intent: ConfigSet Check Ready returned True before per-node reconcilers finished syncing the device, causing Create Deviations For Intent to see 0 deviations instead of 6
- Add per-node Config Check Ready wait after ConfigSet reset
- Add device-state baseline verification (Verify Device Config For Intent) before creating deviations to guarantee a clean starting state
- Add new test suites: 13-srl-onchange-encodings, 14-sros-onchange-sync
- Add intent-routing keyword library with intent/target cache helpers
- Add new discovery and sync profiles for onchange scenarios
- Add miscellaneous supporting input and resource files
- Refactor 22-srl-nonrevertive.robot and 21-sros-nonrevertive.robot: replace single intent-loop test cases with individual tagged test cases per intent, enabling per-intent execution and better failure isolation - Fix race in Reset Intent Baseline For Intent: ConfigSet Check Ready returned True before per-node reconcilers finished syncing the device, causing Create Deviations For Intent to see 0 deviations instead of 6 - Add per-node Config Check Ready wait after ConfigSet reset - Add device-state baseline verification (Verify Device Config For Intent) before creating deviations to guarantee a clean starting state - Add new test suites: 13-srl-onchange-encodings, 14-sros-onchange-sync - Add intent-routing keyword library with intent/target cache helpers - Add new discovery and sync profiles for onchange scenarios - Add miscellaneous supporting input and resource files
henderiw
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.