fix-navegation#606
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL")
Fix: Left/right navigation in conjugation view resets keyboard to alphabetical view
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Cause:
The buttons calls
onConjugateClicked()that reopen conjugation grid.Changes:
The pull request changes the function
onConjugateClicked()on fileGeneralKeyboardIME.kt. Now it changes the conjugation state only when you are not in the conjugation grid.Related issue