Bottleneck matching warning - #109
Open
catanzaromj wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 78.85% 78.87% +0.02%
==========================================
Files 20 20
Lines 1480 1482 +2
Branches 270 271 +1
==========================================
+ Hits 1167 1169 +2
Misses 235 235
Partials 78 78 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
UserWarningonmatching=Truecalls due to the previous change swapping out hopcroftkarp dep for scipy. This warning will be removed in a 0.5.0 release.The warning itself is because when several optimal matchings exist, the bottleneck matching from hopcraftkarp vs scipy may differ. The bottleneck distances themselves are identical, so the warning is only emitted when calling
matching=True. This warning was only noted inRELEASE.txtbefore, so this PR makes it explicit to callers in code.I also added two tests to make sure the warning is only emitted in the correct case.