Fix R CMD check (rename vendored header, refresh workflows) - #31
Merged
Conversation
R CMD check (run with error-on = warning) failed on: checking if this is a source package ... WARNING Subdirectory 'src' contains: nanoflann.hpp R does not accept the .hpp extension in src/. Rename the vendored header src/nanoflann.hpp -> src/nanoflann.h and update the include in mingle.cpp. Also: - bump actions/checkout@v3 -> v4 in both workflows (v3 uses deprecated Node 20) - add inst/COPYRIGHTS documenting the bundled nanoflann BSD license - Rbuildignore .claude Local R CMD check --as-cran is now 0 errors / 0 warnings / 0 notes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
checkout@v4 still targets the deprecated Node 20 runtime; v5 targets Node 24, silencing the deprecation annotation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The R-CMD-check workflow was failing on
main. Two things — a real check WARNING and a stale action.The failure (real WARNING)
R CMD check doesn't accept the
.hppextension insrc/, and CI runserror-on: "warning"(CRAN-like), so this failed the build. Fix: rename the vendored headersrc/nanoflann.hpp→src/nanoflann.h(the.hheaderbundle_geom.hwas already fine) and update the#includeinmingle.cpp.Workflow refresh
actions/checkout@v3→@v4in bothR-CMD-check.yamlandpkgdown.yaml(v3 forces the deprecated Node 20). Ther-lib/actions/*@v2steps are current and unchanged.Housekeeping
inst/COPYRIGHTSdocumenting the bundled nanoflann BSD license (good practice for CRAN)..claude.Verification
Local
R CMD check --as-cran: 0 errors | 0 warnings | 0 notes.devtools::test():PASS 162.🤖 Generated with Claude Code